feat: attest release tarballs with build provenance#84
Open
N4M3Z wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Module release tarballs published through
module-release.yamlcarry no provenance; nothing ties an asset on a GitHub release back to the workflow run and commit that built it.Fix
actions/attest-build-provenanceattestsbuild/*.tar.gzafterforge release, and the workflow declares theid-tokenandattestationspermissions it needs. Consumers can verify assets withgh attestation verify.Callers must grant the two new permissions in their
release.yamljob, or the attestation step fails. Modules pinned to@mainpick this requirement up on their next tag push; modules pinned to a tag (forge-core as of N4M3Z/forge-core#77) adopt it when they bump the pin, so tagging av0.3.3release after this merges gives them a clean target.Test plan
make validategreen (clippy, tests, semgrep, forge validate, secret scan)